feat(ast): introduce CallExpression::arguments_span#12321
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 16, 2025
Merged
Conversation
github-actions
bot
added
A-ast
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
camc314
force-pushed
the
c/07-16-feat_ast_introduce_callexpression_arguments_span_
branch
from
4c80ee4 to
d886650
Compare
CodSpeed Instrumentation Performance ReportMerging #12321 will not alter performanceComparing Summary
|
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
Is this useful? In conversation earlier, I thought @Dunqing was saying that formatter needed the span including the brackets.
foo(bar, baz);
// ^^^^^^^^^^
camc314
force-pushed
the
c/07-16-feat_ast_introduce_callexpression_arguments_span_
branch
from
d886650 to
01e45b0
Compare
Contributor
Author
It'll definitly be useful for the linter, in removing the |
camc314
force-pushed
the
c/07-16-feat_ast_introduce_callexpression_arguments_span_
branch
from
01e45b0 to
7cb3738
Compare
camc314
force-pushed
the
c/07-16-feat_ast_introduce_callexpression_arguments_span_
branch
2 times, most recently
from
46dedea to
61d9623
Compare
overlookmotel
approved these changes
Jul 16, 2025
Member
Merge activity
|
graphite-app
bot
force-pushed
the
c/07-16-feat_ast_introduce_callexpression_arguments_span_
branch
from
61d9623 to
6b8f77d
Compare
graphite-app
bot
deleted the
c/07-16-feat_ast_introduce_callexpression_arguments_span_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
follow on from #12321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.